West Midlands | 2026-ITP-May | Alina Sofragiu | Sprint 1 | Form Controls#1281
West Midlands | 2026-ITP-May | Alina Sofragiu | Sprint 1 | Form Controls#1281sofragiualina wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
6 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sofragiualina
added
the
Needs Review
sofragiualina
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This looks really good, nice styling. I have a question I would like you to answer about the name pattern you are using.
| value="" | ||
| required | ||
| minlength="2" | ||
| pattern=".*\S.*\S.*" |
There was a problem hiding this comment.
What is your goal here - why did you use this particular pattern?
There was a problem hiding this comment.
The goal was to prevent whitespace-only input.pattern=“.\S.\S.*” ensures the value contains at least two non- whitespace characters adding validation on top of required and minlenght=“2” to avoid accidental blank submission
Appreciate the feedback, please feel free to suggest any further improvements or if I need to change anything
There was a problem hiding this comment.
Good explanation! I just wanted to make sure you understood how that pattern works. This solution is complete
There was a problem hiding this comment.
Thank you a lot for the feedback
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size, with built-in validation to ensure all fields are required and correctly formatted.